refactor(view): improve slot importing to prevent view compiler failures #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the content of dynamic slots in the template using normal
var_exportcan cause compiler errors becausevar_exportdoesn't properly escape quoted strings within exported values.To work around that, I added a new
\Tempest\View\Export\ViewObjectExporterthat exports objects to valid PHP code.For now, this exporter is very hard-coded towards this one specific use-case for exporting slots. We might refactor it in the future to be something reusable, and maybe even integrate it with the mapper (something like
map($object)->toPhp(), but that's out of scope for now.)